Quantcast
Channel: lkml.org : Pallipadi, Venkatesh
Viewing all articles
Browse latest Browse all 864

Re: [PATCH 5/9] x86/dumpstack: Improve opcodes dumping in the Code ...

$
0
0
Linus Torvalds writes: (Summary) wrote:

[...]

+ unsigned int code_prologue = OPCODE_BUFSIZE * 43 / OPCODE_BUFSIZE; Heh.
Heh.
That's a very odd way of writing "43".
That's a very odd way of writing "43".
Honestly, the "43" is just "two thirds" rounded to closest, and it's not important anyway, so I think you should just write it as not important anyway, so I think you should just write it as unsigned int code_prologue = OPCODE_BUFSIZE * 2 / 3; and never mind that it will now be 42.
and never mind that it will now be 42.
42 is obviously the right answer anyway, which makes me think we got it wrong earlier.
it wrong earlier.
Linus
Linus
Linus

Viewing all articles
Browse latest Browse all 864

Trending Articles