Linus Torvalds writes: (Summary) wrote:
Please stop this garbage.
Please stop this garbage.
The rule is simple: DO NOT DO THAT THEN.
The rule is simple: DO NOT DO THAT THEN.
Don't make recursive locks. Just stop doing the thing that hurts.
doing the thing that hurts.
There is no valid reason why an UART driver should do a printk() of any sort inside the critical region where the console is locked. We fix the bug - by removing the problematic printk.
fix the bug - by removing the problematic printk.
Linus
Linus
Linus
[...]
all the mentioned deadlocks.Please stop this garbage.
Please stop this garbage.
The rule is simple: DO NOT DO THAT THEN.
The rule is simple: DO NOT DO THAT THEN.
Don't make recursive locks. Just stop doing the thing that hurts.
doing the thing that hurts.
There is no valid reason why an UART driver should do a printk() of any sort inside the critical region where the console is locked. We fix the bug - by removing the problematic printk.
fix the bug - by removing the problematic printk.
Linus
Linus
Linus