Linus Torvalds writes: (Summary) wrote:
That would definitely make me happier.
That would definitely make me happier.
Right now we already remove the actual device node sysfs associations synchronously with "kobject_del()" (even if it still then stays around as a kobject), and that does the remove for the object itself - just not the glue directory.
not the glue directory.
If we then just did a "if glue dir is empty, delete the glue dir too" in cleanup_glue_dir(), at least ther patch would be prettier. +} + /* * make sure cleaning up dir as the last step, we need to make * sure .release handler of kobject is run with holding the @@ -1597,6 +1603,10 @@ static void cleanup_glue_dir(struct device *dev, struct kobject *glue_dir) return;
[...]
smaller/simpler.That would definitely make me happier.
That would definitely make me happier.
Right now we already remove the actual device node sysfs associations synchronously with "kobject_del()" (even if it still then stays around as a kobject), and that does the remove for the object itself - just not the glue directory.
not the glue directory.
If we then just did a "if glue dir is empty, delete the glue dir too" in cleanup_glue_dir(), at least ther patch would be prettier. +} + /* * make sure cleaning up dir as the last step, we need to make * sure .release handler of kobject is run with holding the @@ -1597,6 +1603,10 @@ static void cleanup_glue_dir(struct device *dev, struct kobject *glue_dir) return;