Linus Torvalds writes: (Summary) wrote:
This one is written kind of stupidly.
This one is written kind of stupidly.
The code went from the original
The code went from the original
groups &= (1UL << nlk->ngroups) - 1;
groups &= (1UL << nlk->ngroups) - 1;
(which is incorrect for large values of nlk->ngroups) to the fixed (which is incorrect for large values of nlk->ngroups) to the fixed
[...]
gruops, from Dmitry Safonov.This one is written kind of stupidly.
This one is written kind of stupidly.
The code went from the original
The code went from the original
groups &= (1UL << nlk->ngroups) - 1;
groups &= (1UL << nlk->ngroups) - 1;
(which is incorrect for large values of nlk->ngroups) to the fixed (which is incorrect for large values of nlk->ngroups) to the fixed
if (nlk->ngroups == 0) groups = 0;