Re: [GIT PULL] Staging driver fixes for 4.15-rc4
Linus Torvalds writes: (Summary) On Fri, Dec 15, 2017 at 11:00 AM, Greg KH <gregkh@linuxfoundation.org> wrote: [...] patch got reverted due to build errors reported by 0-day. Since the revert was...
View ArticleRe: [PATCH v2 01/17] mm/gup: Fixup p*_access_permitted()
Linus Torvalds writes: (Summary) Also, while I think we *should* check the PAGE_USER bit when walking the page tables, like we used to, we should the page tables, like we used to, we should (a) do it...
View ArticleRe: [PATCH v2 01/17] mm/gup: Fixup p*_access_permitted()
Linus Torvalds writes: (Summary) We'd have to do something like put the !PAGE_USER mapping at the top of the user address space, and then simply make user_addr_max() smaller than the actual user page...
View ArticleRe: [PATCH v2 01/17] mm/gup: Fixup p*_access_permitted()
Linus Torvalds writes: (Summary) wrote: [...] So do you want to do a straight revert of these that went in for 4.15: I think that's the right thing to do, but would want to verify that there are no...
View ArticleRe: [PATCH v2 01/17] mm/gup: Fixup p*_access_permitted()
Linus Torvalds writes: (Summary) But part of it is also that we should fall back to the slow case if the fast case doesn't work (eg because the page isn't there or whatever). whatever). So what we...
View ArticleRe: [PATCH v2 01/17] mm/gup: Fixup p*_access_permitted()
Linus Torvalds writes: (Summary) On Fri, Dec 15, 2017 at 6:48 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: [...] deal with the checks" should be fine Well, it's *semantically* fine and I think...
View ArticleRe: [PATCH v2 01/17] mm/gup: Fixup p*_access_permitted()
Linus Torvalds writes: (Summary) wrote:[...] practice. Anyway, I reverted the three commits Dan pointed to, and we can always revisit the exact path forward later revisit the exact path forward later...
View ArticleRe: [RFC GIT PULL] x86 Page Table Isolation (PTI) syscall entry co ...
Linus Torvalds writes: (Summary) But look at that merge (on the "other side"), and notice how the end result is *not* identical to the parent. the end result is *not* identical to the parent. IOW, that...
View ArticleRe: [linus:master] BUILD REGRESSION f3b5ad89de16f5d42e8ad36fbdf85f ...
Linus Torvalds writes: (Summary) Nico, Nico, On Sat, Dec 16, 2017 at 7:00 PM, kbuild test robot<fengguang.wu@intel.com> wrote:[...] fs/cramfs/inode.c:959: undefined reference to `mount_mtd' This...
View ArticleRe: [GIT PULL REQUEST] watchdog - v4.15 Fixes
Linus Torvalds writes: (Summary) We've found that lots of messages from iguana.be are spam. iguana.be are spam. I have no idea why that site is so hated, but one option that your upstream ISP is some...
View ArticleRe: [linus:master] BUILD REGRESSION f3b5ad89de16f5d42e8ad36fbdf85f ...
Linus Torvalds writes: On Sun, Dec 17, 2017 at 7:25 AM, Al Viro <viro@zeniv.linux.org.uk> wrote: [...] pull request? I just took it directly, since you had in the meantime already generated the...
View ArticleRe: [GIT PULL REQUEST] watchdog - v4.15 Fixes
Linus Torvalds writes: (Summary) wrote:[...] got.. Oh, and equally importantly, it's an unsigned pull request from a non-secured site, so I think I'll skip this. non-secured site, so I think I'll skip...
View ArticleRe: [RFC patch] checkpatch: Add a test for long function definitio ...
Linus Torvalds writes: (Summary) wrote: [...] function definitions. So I'm not sure a line count makes sense. So I'm not sure a line count makes sense. Sometimes long functions can be sensible, if they...
View ArticleRe: [GIT PULL] Page Table Isolation (PTI) v4.14 backporting base tree
Linus Torvalds writes: (Summary) Ok, so I've pulled the two prep trees, since they are obviously safe and don't change any code. and don't change any code. I'm going to read through the actual real...
View ArticleRe: [RFC GIT PULL] Page Table Isolation (PTI), x86 syscall entry c ...
Linus Torvalds writes: (Summary) On Sun, Dec 17, 2017 at 7:24 AM, Ingo Molnar <mingo@kernel.org> wrote: [...] Please pull the latest WIP.x86-pti.entry-for-linus git tree from: Ok, with rc4 out of...
View ArticleRe: [PATCH] kthread: finer-grained lockdep/cross-release completion
Linus Torvalds writes: (Summary) wrote: [...] going? Do you actually see the problem in -rc4? Do you actually see the problem in -rc4? Because we ended up removing the cross-release checking due to...
View ArticleRe: [PATCH] trace/uprobes: fix output issue with address randomization
Linus Torvalds writes: (Summary) Shouldn't it? So %p itself shouldn't have logic like that, because some of those addresses can be sensitive even if they aren't strictly kernel addresses. addresses....
View ArticleRe: proc_flush_task oops
Linus Torvalds writes: (Summary) The code disassembles to The code disassembles to 0: c1 e2 04 shl $0x4,%edx 3: 44 8b 60 30 mov 0x30(%rax),%r12d 7: 48 8b 40 38 mov 0x38(%rax),%rax b: 44 8b 34 11 mov...
View ArticleRe: BUG: bad usercopy in memdup_user
Linus Torvalds writes: (Summary) But if it does, it should just be changed to %px, since it's a bug report. bug report. But honestly, what do people expect that the pointer value will actually tell you...
View ArticleRe: BUG: bad usercopy in memdup_user
Linus Torvalds writes: (Summary) But that's for a faulting address when you have an invalid pointer. But that's for a faulting address when you have an invalid pointer. That's not the case here at all....
View Article