Re: [PATCH 2/6] x86: bug: prevent gcc distortions
Linus Torvalds writes: (Summary) header file that has these kinds of macros (or "pseudo-instructions") for assembly language cases, and then we could just rely on them in inline asm. could just rely on...
View ArticleRe: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
Linus Torvalds writes: (Summary) Particularly since it's probably just one specific list where you want this oddly specific behavior. list where you want this oddly specific behavior. Also, if we...
View ArticleRe: [PATCH 2/6] x86: bug: prevent gcc distortions
Linus Torvalds writes: On Fri, May 18, 2018 at 10:24 AM Nadav Amit <namit@vmware.com> wrote: On Fri, May 18, 2018 at 10:24 AM Nadav Amit <namit@vmware.com> wrote: [...] =E2=80=9D...
View ArticleRe: [PATCH 2/6] x86: bug: prevent gcc distortions
Linus Torvalds writes: (Summary) On Fri, May 18, 2018 at 11:34 AM <hpa@zytor.com> We already do something like that for real *.S files on some architectures (because their assembly really wants...
View ArticleRe: [PATCH 2/6] x86: bug: prevent gcc distortions
Linus Torvalds writes: (Summary) And yes, like hpa says, we should make sure that behavior is acknowledged by the GNU as people, so that they then don't come back and say "hey, now we assemble things...
View ArticleRe: [PATCH 2/6] x86: bug: prevent gcc distortions
Linus Torvalds writes: (Summary) On Fri, May 18, 2018 at 12:18 PM Nadav Amit <namit@vmware.com> wrote: On Fri, May 18, 2018 at 12:18 PM Nadav Amit <namit@vmware.com> The source program is...
View ArticleRe: [PATCH] procfs: fix mmap() for /proc/vmcore
Linus Torvalds writes: (Summary) On Fri, May 18, 2018 at 8:15 PM Vasily Gorbik <gor@linux.ibm.com> wrote: On Fri, May 18, 2018 at 8:15 PM Vasily Gorbik <gor@linux.ibm.com> If proc doesn't...
View ArticleRe: [PATCH] procfs: fix mmap() for /proc/vmcore
Linus Torvalds writes: (Summary) I was going to point to the s_maxbytes check in rw_verify_area() and ask you how that ever worked for that file, but it's not there, the s_maxbyte checks are only in...
View ArticleRe: [PATCH] procfs: fix mmap() for /proc/vmcore
Linus Torvalds writes: (Summary) 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index a45f0af22a60..83278c547127 100644 --- a/fs/proc/vmcore.c +++...
View ArticleRe: [PATCH] procfs: fix mmap() for /proc/vmcore
Linus Torvalds writes: (Summary) On Fri, May 18, 2018 at 9:12 PM Linus Torvalds < wrote:[...] superblock"). Actually, maybe we could just make rw_verify_area() use the new file_mmap_size_max()...
View ArticleRe: [PATCH] procfs: fix mmap() for /proc/vmcore
Linus Torvalds writes: (Summary) wrote: [...] so, as it is this patch does not fix the issue. Right you are. Right you are. We could easily reverse the order of those two checks, but since clearly the...
View ArticleRe: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
Linus Torvalds writes: (Summary) The whole chain to look up the pointer you are taking 'next' of needs to be under RCU, and that's not clear from your example. 'next' of needs to be under RCU, and...
View ArticleRe: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
Linus Torvalds writes: (Summary) Once we get to "take the next entry, but skip it if it's the head entry, and then return NULL if you get back to the entry you started with" kind of semantics, an...
View ArticleRe: [GIT PULL] Btrfs fixes for 4.17-rc6
Linus Torvalds writes: (Summary) On Sun, May 20, 2018 at 8:21 AM David Sterba <dsterba@suse.com> Especially with the tree-log.c changes being fairly big, I took a look, and I have to say that I...
View ArticleLinux 4.17-rc6
Linus Torvalds writes: (Summary) Tsirkin (1): kvm: rename KVM_HINTS_DEDICATED to KVM_HINTS_REALTIME Michel Thierry (1): drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk Miquel Raynal (1):...
View ArticleRe: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
Linus Torvalds writes: (Summary) You're using a pointer where the lifetime has nothing to do with RCU any more. nothing to do with RCU any more. Can it be done? But you need *other* locking for it...
View ArticleRe: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
Linus Torvalds writes: (Summary) Even if we go your way, there is *one* single user, and that one is special and needs to take a lot more care. special and needs to take a lot more care. Just roll your...
View ArticleRe: write_lock_irq(&tasklist_lock)
Linus Torvalds writes: (Summary) It covers too much, but trying to split it up has never worked well. split it up has never worked well. It's usually not a huge problem because there are so few...
View ArticleRe: write_lock_irq(&tasklist_lock)
Linus Torvalds writes: (Summary) We actually have a special rule to make it *not* be fair, in that interrupts are allowed to take the read lock if there are readers - even if there are waiting writers....
View ArticleRe: write_lock_irq(&tasklist_lock)
Linus Torvalds writes: (Summary) On Wed, May 23, 2018 at 6:05 AM Will Deacon <will.deacon@arm.com> Oh, I didn't even realize that this wasn't x86, and that there was still the very unfair rwlock...
View Article