Re: [PATCH 4/4] fs/dcache: Avoid the try_lock loops in dentry_kill()

Linus Torvalds writes: (Summary) wrote:

[...]

d_prune_aliases(), for example.
What are you talking about?
What are you talking about?
lock_parent() does the nice "spin_trylock succeeded" special case. lock_parent() does the nice "spin_trylock succeeded" special case. You remove the simple case, and make dentry_kill() do the "recheck in case I dropped" every single time.
dropped" every single time.
It's the "turn a simple case into a complex case" that I absolutely detest. It's the "turn a simple case into a complex case" that I absolutely detest. The fact that there are _other_ complex cases doesn't make it any better.