Re: [PATCH 4/4] fs/dcache: Avoid the try_lock loops in dentry_kill()

Linus Torvalds writes: (Summary) You can't just move the trylock into the caller, since then you need to move all the other stuff too?
to move all the other stuff too?
Or were you planning on splitting lock_parent() into two, for the "fast case vs compex case"?
"fast case vs compex case"?
Or maybe I'm entirely missing something and we're miscommunicating. Your d_delete() patch didn't make me go "that looks more complicated", probably partl ybecause of the nice helper function.
function.
So it may be that my dislike of the "re-check after possibly dropping the lock" is not really about the re-checking, but about just how it made that function look much more complicated.
made that function look much more complicated.
Linus
Linus
Linus